Skip to content

Add support for local server graceful shutdown #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2025
Merged

Add support for local server graceful shutdown #519

merged 2 commits into from
Jun 29, 2025

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Jun 29, 2025 •
edited
Loading

  • Add ServiceLifecycle version of LambdaRuntime.run that wraps internal _run call in cancelOnGracefulShutdown
  • Add cancellation handlers for shutting down existing connections in Local lambda
  • Added test for lambda graceful shutdown

Motivation:

Ensure local lambda supports graceful shutdown

@adam-fowler adam-fowler added the 🔨 semver/patch No public API change. label Jun 29, 2025
@sebsto sebsto self-requested a review June 29, 2025 07:04
sebsto
sebsto approved these changes Jun 29, 2025
View reviewed changes
Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@sebsto sebsto merged commit b2811a5 into main Jun 29, 2025
61 of 64 checks passed
@sebsto sebsto deleted the local-server-graceful-shutdown branch June 29, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebsto sebsto sebsto approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-fowler @sebsto